Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue77-migrate-to-vite #81

Merged
merged 22 commits into from
Feb 27, 2024
Merged

Issue77-migrate-to-vite #81

merged 22 commits into from
Feb 27, 2024

Conversation

k-allagbe
Copy link
Member

Closes #77: Migrate from CRA to Vite

  • migration
  • update tests
  • update doc
  • update version

@k-allagbe k-allagbe marked this pull request as draft February 1, 2024 09:11
@k-allagbe k-allagbe force-pushed the issue77-migrate-to-vite branch from 1d92d0e to 48cf882 Compare February 1, 2024 09:30
@k-allagbe k-allagbe force-pushed the issue77-migrate-to-vite branch from 48cf882 to f5b00cc Compare February 1, 2024 09:37
@k-allagbe
Copy link
Member Author

k-allagbe commented Feb 1, 2024 •
edited
Loading

@ThomasCardin I may have broken the lint-test workflow for this repo. Please could you take a look.
image

I opened this ai-cfia/github-workflows#85 which might fix it.
Please, note that:

  • the npm version 9 is no longer required
  • the env vars have changed. The required REACT_APP_ prefix is now VITE_.

rngadam
rngadam suggested changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that @CFIALeronB has reviewed this change

@k-allagbe k-allagbe marked this pull request as ready for review February 8, 2024 07:31
@k-allagbe k-allagbe marked this pull request as draft February 8, 2024 07:45
@k-allagbe k-allagbe force-pushed the issue77-migrate-to-vite branch from db6450b to aef9f25 Compare February 8, 2024 07:45
@k-allagbe k-allagbe force-pushed the issue77-migrate-to-vite branch from aef9f25 to 7224287 Compare February 8, 2024 07:49
CFIALeronB
CFIALeronB approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@CFIALeronB CFIALeronB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be in working well using vite

@k-allagbe
Copy link
Member Author

k-allagbe commented Feb 8, 2024 •
edited
Loading

@ThomasCardin please could you look at these:
https://github.com/ai-cfia/finesse-frontend/actions/runs/7826419055/job/21352248374?pr=81
https://github.com/ai-cfia/finesse-frontend/actions/runs/7826419055/job/21352248544?pr=81

I have no clue what's happening.

@k-allagbe k-allagbe marked this pull request as ready for review February 27, 2024 14:24
@k-allagbe k-allagbe merged commit de301f1 into main Feb 27, 2024
7 checks passed
@k-allagbe k-allagbe mentioned this pull request Feb 28, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rngadam rngadam rngadam approved these changes

@CFIALeronB CFIALeronB CFIALeronB approved these changes

@ThomasCardin ThomasCardin Awaiting requested review from ThomasCardin

Assignees
No one assigned
Labels
None yet
Projects
Finesse
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate finesse-frontend from Create-React-App
3 participants
@k-allagbe @rngadam @CFIALeronB